code-review-guidelines

Included with Lifetime

$97 forever

Use when reviewing code changes or pull requests. Provides the foundational rules, principles, and checklists for all code review agents.

Code Review

What this skill does


# Code Review Guidelines

Reference knowledge for code review agents. Load this skill to understand review scope, filtering rules, and quality standards.

## The Changed Lines Rule

**This rule is non-negotiable for all review agents.**

Review scope is LIMITED to lines that were ADDED or MODIFIED in the diff:

- `+` lines (additions) - reviewable
- Modified lines - reviewable
- Unchanged lines - NOT reviewable (context only)
- Pre-existing issues - NOT reviewable

**Silent filtering**: Skip pre-existing issues without mention. Do not say "I found X but it's pre-existing." Simply omit them entirely.

**Verification**: Before reporting any issue, confirm the line appears in the diff as an addition or modification.

## Review Principles

1. **Signal over noise** - Report issues that matter, skip nitpicks
2. **Actionable feedback** - Every issue includes a concrete fix
3. **Evidence-based** - Cite file paths and line numbers
4. **Context-aware** - Check project guidelines (CLAUDE.md, README.md) first
5. **Pragmatic** - Consider cost/benefit of each finding

## Output Standards

All review agents use consistent output:

| File | Line | Type | Issue | Fix |
|------|------|------|-------|-----|
| `path/file.ts` | 42 | Type | 10 words max | 10 words max |

**Type labels**:
- Bug - Logic errors, crashes, data issues
- Security - Vulnerabilities, auth issues
- Quality - Maintainability, patterns
- Test - Missing coverage
- Contract - API/type design issues
- Context - Historical patterns

## Reference Checklists

Detailed checklists are available in `references/`:

- `code-quality-checklist.md` - Clean code, SOLID, naming, architecture
- `security-checklist.md` - OWASP-aligned security checks
- `contracts-checklist.md` - API and type design checks
- `test-coverage-checklist.md` - Test quality and coverage checks

Load specific checklists only when needed for that review type.

## Severity Classification

| Level | Criteria | Action |
|-------|----------|--------|
| Critical | Data loss, security breach, production outage | Block merge |
| High | Core feature broken, significant bug | Should fix before merge |
| Medium | Edge case issues, maintainability | Consider fixing |
| Low | Minor improvements, style | Optional |

## Confidence Thresholds

Issues must meet minimum confidence for their impact level:

| Impact | Min Confidence | Rationale |
|--------|---------------|-----------|
| Critical (81-100) | 50% | Investigate even with moderate confidence |
| High (61-80) | 65% | Avoid false alarms on important issues |
| Medium (41-60) | 75% | Need high confidence to justify effort |
| Low (21-40) | 85% | Only report if very confident |
| Minor (0-20) | 95% | Only if nearly certain |

Files: 5

Size: 13.6 KB

Complexity: 34/100

Category: Code Review

Source: https://github.com/dnlopes/claude-code-plugins/tree/main/review-toolkit/skills/code-review-guidelines

Related in Code Review

gstack

Included

Fast headless browser for QA testing and site dogfooding. Navigate pages, interact with elements, verify state, diff before/after, take annotated screenshots, test responsive layouts, forms, uploads, dialogs, and capture bug evidence. Use when asked to open or test a site, verify a deployment, dogfood a user flow, or file a bug with screenshots. (gstack)

Code Reviewscriptsfeatured

startup-due-diligence

Included

Legal due diligence review for seed-stage and Series A startups (US, Delaware C-Corp focus). Supports both investor and founder perspectives. Capabilities include: (1) Interactive document review and issue spotting; (2) Document request list generation; (3) Cap table and SAFE/convertible note analysis; (4) Red flag identification with severity ratings; (5) Diligence report generation. TRIGGERS: due diligence, DD, startup investment, cap table review, Series A, seed round, investor diligence, legal review startup, SAFE analysis, convertible note, 409A, founder vesting.

Code Reviewscripts

interview-master

Included

This skill should be used when the user asks to "generate interview questions", "prepare for interview", "optimize resume", "conduct mock interview", "analyze git commits for resume", "generate resume from code", "review my resume", or mentions interview preparation, career assistance, or extracting project experience from git history. Provides comprehensive interview and career development guidance for both job seekers and interviewers.

Code Reviewscripts

fix-issue

Included

Fixes GitHub issues using parallel analysis agents for root cause investigation, code exploration, and regression detection. Reads issue context from gh CLI, searches codebase and memory for related patterns, generates a fix with tests, and links the resolution back to the issue via PR. Includes prevention analysis to avoid recurrence. Use when debugging errors, resolving regressions, fixing bugs, or triaging issues.

Code Reviewscripts

sf-apex

Included

Generates and reviews Salesforce Apex code with 150-point scoring. TRIGGER when: user writes, reviews, or fixes Apex classes, triggers, test classes, batch/queueable/schedulable jobs, or touches .cls/.trigger files. DO NOT TRIGGER when: LWC JavaScript (use sf-lwc), Flow XML (use sf-flow), SOQL-only queries (use sf-soql), or non-Salesforce code.

Code Reviewscripts

swift-development

Included

Comprehensive Swift development for building, testing, and deploying iOS/macOS applications. Use when Claude needs to: (1) Build Swift packages or Xcode projects from command line, (2) Run tests with XCTest or Swift Testing framework, (3) Manage iOS simulators with simctl, (4) Handle code signing, provisioning profiles, and app distribution, (5) Format or lint Swift code with SwiftFormat/SwiftLint, (6) Work with Swift Package Manager (SPM), (7) Implement Swift 6 concurrency patterns (async/await, actors, Sendable), (8) Create SwiftUI views with MVVM architecture, (9) Set up Core Data or SwiftData persistence, or any other Swift/iOS/macOS development tasks.

Code Reviewscripts