code-standards
Code quality standards and style guide for reviewing pull requests
What this skill does
# Code Standards Review When reviewing code, follow this structured process: ## Step 1: Critical Issues Check for issues that MUST be fixed before merging: - Logic bugs and incorrect behavior - Missing error handling for failure cases - Race conditions or concurrency issues - Unhandled edge cases (null, undefined, empty arrays, boundary values) - Breaking API changes without migration path ## Step 2: Code Quality Evaluate overall code quality: - Functions should do one thing and be reasonably sized (< 50 lines preferred) - Avoid code duplication — look for repeated patterns that should be abstracted - Use descriptive, meaningful names for variables, functions, and types - Prefer explicit types over `any` in TypeScript - Ensure proper use of async/await (no floating promises, proper error propagation) ## Step 3: Style Guide Conformance Check against the style guide in `references/style-guide.md`: - Naming conventions - Code organization and import ordering - Comment quality (explain "why", not "what") ## Step 4: Linting Flags Flag these patterns: - `var` usage (should be `const` or `let`) - Leftover `console.log` or `debugger` statements - Commented-out code blocks - Magic numbers without named constants - `TODO` or `FIXME` comments without issue references ## Output Format Structure your feedback as: 1. **Summary**: 1-2 sentence overview of the changes and overall quality 2. **Critical Issues**: Must-fix problems with file path and line numbers 3. **Suggestions**: Improvements that would make the code better 4. **Positive Notes**: Good patterns and decisions worth acknowledging
Related in General
modeling-omnistudio-epc-catalog
IncludedSalesforce Industries CME EPC product-modeling skill for Product2-based catalog creation. Use when creating EPC products, configuring product attributes, building offer bundles with Product Child Items, or reviewing EPC DataPack JSON metadata for product catalog changes. TRIGGER when: user creates or updates Product2 EPC records, AttributeAssignment payloads, AttributeMetadata/AttributeDefaultValues, Offer bundles, or ProductChildItem relationships. DO NOT TRIGGER when: designing OmniScripts/FlexCards/Integration Procedures (use building-omnistudio-omniscript, building-omnistudio-flexcard, or building-omnistudio-integration-procedure), implementing Apex business logic (use generating-apex), or troubleshooting deployment pipelines (use deploying-metadata).
relationship-science-coach
IncludedUse this skill for direct, practical adult relationship coaching: couples conflict, repair, trust, marriage, dating, flirting, attachment patterns, emotional connection, sex, desire differences, eroticism, kink negotiation, affection, love languages, breakups, and long-term passion. Draw on Gottman, EFT and Hold Me Tight, attachment science, modern sex research, Perel, Nagoski, Kerner, Schnarch, Love and Stosny, and flexible love-language tools. Be concrete and low-hedge. Redirect only for imminent danger, abuse, coercive control, minors, non-consent, self-harm, stalking, or medical/legal/psychiatric decisions.
building-sf-integrations
IncludedSalesforce integration architecture and runtime plumbing with 120-point scoring. Use this skill to set up Named Credentials, External Credentials, External Services, REST/SOAP callout patterns, Platform Events, and Change Data Capture. TRIGGER when: user sets up Named Credentials, External Services, REST/SOAP callouts, Platform Events, CDC, or touches .namedCredential-meta.xml files. DO NOT TRIGGER when: Connected App/OAuth config (use configuring-connected-apps), Apex-only logic (use generating-apex), or data import/export (use handling-sf-data).
venue-templates
IncludedAccess comprehensive LaTeX templates, formatting requirements, and submission guidelines for major scientific publication venues (Nature, Science, PLOS, IEEE, ACM), academic conferences (NeurIPS, ICML, CVPR, CHI), research posters, and grant proposals (NSF, NIH, DOE, DARPA). This skill should be used when preparing manuscripts for journal submission, conference papers, research posters, or grant proposals and need venue-specific formatting requirements and templates.
let-fate-decide
IncludedDraws the 12 Houses of the Zodiac Tarot spread to inject entropy into planning when prompts are vague, ambiguous, or casually delegated. Interprets the spread to guide next steps. Use when the user says 'let fate decide', 'YOLO', 'whatever', 'idk', or other nonchalant phrases, makes Yu-Gi-Oh references, or when you are about to arbitrarily pick between multiple reasonable approaches. Prefer over ask-questions-if-underspecified when the user's tone is casual or playful rather than precision-seeking.
net-ops
IncludedCross-platform network troubleshooting (Windows, macOS, Linux) via local or remote shell. Use for: DNS broken, can't resolve hostnames, nslookup/dig works but apps fail, NRPT, WFP, scutil, /etc/resolver, systemd-resolved, /etc/resolv.conf, NetworkManager, VPN DNS leak residue (ProtonVPN/Mullvad/WireGuard/AnyConnect), AV/firewall blocking DNS or DoH, Tailscale DNS interaction, intermittent connectivity, remote diagnostics over SSH.