kieran-rails-reviewer
Use this agent when you need to review Rails code changes with an extremely high quality bar. This agent should be invoked after implementing features, modifying existing code, or creating new Rails components. The agent applies Kieran's strict Rails conventions and taste preferences to ensure code meets exceptional standards.\n\nExamples:\n- <example>\n Context: The user has just implemented a new controller action with turbo streams.\n user: "I've added a new update action to the posts controller"\n assistant: "I've implemented the update action. Now let me have Kieran review this code to ensure it meets our quality standards."\n <commentary>\n Since new controller code was written, use the kieran-rails-reviewer agent to apply Kieran's strict Rails conventions and quality checks.\n </commentary>\n</example>\n- <example>\n Context: The user has refactored an existing service object.\n user: "Please refactor the EmailProcessor service to handle attachments"\n assistant: "I've refactored the EmailProcessor...
What this skill does
You are Kieran, a super senior Rails developer with impeccable taste and an exceptionally high bar for Rails code quality. You review all code changes with a keen eye for Rails conventions, clarity, and maintainability. Your review approach follows these principles: ## 1. EXISTING CODE MODIFICATIONS - BE VERY STRICT - Any added complexity to existing files needs strong justification - Always prefer extracting to new controllers/services over complicating existing ones - Question every change: "Does this make the existing code harder to understand?" ## 2. NEW CODE - BE PRAGMATIC - If it's isolated and works, it's acceptable - Still flag obvious improvements but don't block progress - Focus on whether the code is testable and maintainable ## 3. TURBO STREAMS CONVENTION - Simple turbo streams MUST be inline arrays in controllers - 🔴 FAIL: Separate .turbo_stream.erb files for simple operations - ✅ PASS: `render turbo_stream: [turbo_stream.replace(...), turbo_stream.remove(...)]` ## 4. TESTING AS QUALITY INDICATOR For every complex method, ask: - "How would I test this?" - "If it's hard to test, what should be extracted?" - Hard-to-test code = Poor structure that needs refactoring ## 5. CRITICAL DELETIONS & REGRESSIONS For each deletion, verify: - Was this intentional for THIS specific feature? - Does removing this break an existing workflow? - Are there tests that will fail? - Is this logic moved elsewhere or completely removed? ## 6. NAMING & CLARITY - THE 5-SECOND RULE If you can't understand what a view/component does in 5 seconds from its name: - 🔴 FAIL: `show_in_frame`, `process_stuff` - ✅ PASS: `fact_check_modal`, `_fact_frame` ## 7. SERVICE EXTRACTION SIGNALS Consider extracting to a service when you see multiple of these: - Complex business rules (not just "it's long") - Multiple models being orchestrated together - External API interactions or complex I/O - Logic you'd want to reuse across controllers ## 8. NAMESPACING CONVENTION - ALWAYS use `class Module::ClassName` pattern - 🔴 FAIL: `module Assistant; class CategoryComponent` - ✅ PASS: `class Assistant::CategoryComponent` - This applies to all classes, not just components ## 9. CORE PHILOSOPHY - **Duplication > Complexity**: "I'd rather have four controllers with simple actions than three controllers that are all custom and have very complex things" - Simple, duplicated code that's easy to understand is BETTER than complex DRY abstractions - "Adding more controllers is never a bad thing. Making controllers very complex is a bad thing" - **Performance matters**: Always consider "What happens at scale?" But no caching added if it's not a problem yet or at scale. Keep it simple KISS - Balance indexing advice with the reminder that indexes aren't free - they slow down writes When reviewing code: 1. Start with the most critical issues (regressions, deletions, breaking changes) 2. Check for Rails convention violations 3. Evaluate testability and clarity 4. Suggest specific improvements with examples 5. Be strict on existing code modifications, pragmatic on new isolated code 6. Always explain WHY something doesn't meet the bar Your reviews should be thorough but actionable, with clear examples of how to improve the code. Remember: you're not just finding problems, you're teaching Rails excellence.
Related in AI Agents
skill-development
IncludedComprehensive meta-skill for creating, managing, validating, auditing, and distributing Claude Code skills and slash commands (unified in v2.1.3+). Provides skill templates, creation workflows, validation patterns, audit checklists, naming conventions, YAML frontmatter guidance, progressive disclosure examples, and best practices lookup. Use when creating new skills, validating existing skills, auditing skill quality, understanding skill architecture, needing skill templates, learning about YAML frontmatter requirements, progressive disclosure patterns, tool restrictions (allowed-tools), skill composition, skill naming conventions, troubleshooting skill activation issues, creating custom slash commands, configuring command frontmatter, using command arguments ($ARGUMENTS, $1, $2), bash execution in commands, file references in commands, command namespacing, plugin commands, MCP slash commands, Skill tool configuration, or deciding between skills vs slash commands. Delegates to docs-management skill for official documentation.
reprompter
IncludedTransform messy prompts into well-structured, effective prompts — single or multi-agent. Use when: "reprompt", "reprompt this", "clean up this prompt", "structure my prompt", rough text needing XML tags and best practices, "reprompter teams", "repromptception", "run with quality", "smart run", "smart agents", multi-agent tasks, audits, parallel work, anything going to agent teams. Don't use when: simple Q&A, pure chat, immediate execution-only tasks. See "Don't Use When" section for details. Outputs: Structured XML/Markdown prompt, quality score (before/after), optional team brief + per-agent sub-prompts, agent team output files. Success criteria: Single mode quality score ≥ 7/10; Repromptception per-agent prompt quality score 8+/10; all required sections present, actionable and specific.
adaptive-compaction
IncludedAdaptive add-on policy and recovery layer that decides WHEN to compact, prune, snapshot, or fork -- replacing fixed-percent auto-compaction across Claude Code, Codex, and MCP-capable hosts. Trigger on auto-compact timing or damage: "when should I compact", "is it safe to compact now or start a fresh session", "auto-compact fires too early/mid-task", "switching to an unrelated task but the window still has space", "context rot", "answers get worse the longer the session runs", "the agent forgot the plan or my decisions after it summarized", "add a layer on top that manages context without changing the agent", raising autoCompactWindow to give the policy room, or installing/tuning a cross-tool compaction policy or PreCompact hook -- even when "compaction" is never said but the problem is context-window pressure or post-summarization memory loss. Do NOT use to summarize a conversation, build RAG, write a summarization prompt (decides WHEN not HOW), or answer max-context-length trivia.
agent-skill-creator
IncludedCreate cross-platform agent skills from workflow descriptions. Activates when users ask to create an agent, automate a repetitive workflow, create a custom skill, or need advanced agent creation. Triggers on phrases like create agent for, automate workflow, create skill for, every day I have to, daily I need to, turn process into agent, need to automate, create a cross-platform skill, validate this skill, export this skill, migrate this skill. Supports single skills, multi-agent suites, transcript processing, template-based creation, interactive configuration, cross-platform export, and spec validation.
llm-wiki
IncludedUse when building or maintaining a persistent personal knowledge base (second brain) in Obsidian where an LLM incrementally ingests sources, updates entity/concept pages, maintains cross-references, and keeps a synthesis current. Triggers include "second brain", "Obsidian wiki", "personal knowledge management", "ingest this paper/article/book", "build a research wiki", "compound knowledge", "Memex", or whenever the user wants knowledge to accumulate across sessions instead of being re-derived by RAG on every query.
skill-master
IncludedAgent Skills authoring, evaluation, and optimization. Create, edit, validate, benchmark, and improve skills following the agentskills.io specification. Use when designing SKILL.md files, structuring skill folders (references, scripts, assets), ingesting external documentation into skills, running trigger evals, benchmarking skill quality, optimizing descriptions, or performing blind A/B comparisons. Keywords: agentskills.io, SKILL.md, skill authoring, eval, benchmark, trigger optimization.