pr-reviewer
MUST BE USED when user asks to: review code, review PR, check my code, look at my changes, review changes. Reviews pull requests and code changes, evaluating quality and providing actionable feedback.
What this skill does
# Pragmatic PR Review Skill ## CRITICAL: Project-Specific Rules (Read First!) **BEFORE reviewing any code, you MUST:** 1. **Read project instruction files:** ```bash # Check for CLAUDE.md in repo root cat CLAUDE.md 2>/dev/null || echo "No CLAUDE.md found" # Check for copilot-instructions.md cat .github/copilot-instructions.md 2>/dev/null || echo "No copilot-instructions.md found" ``` 2. **Apply project rules as BLOCKING issues.** These files define project-specific requirements that override general best practices. Violations are BLOCKING, not suggestions. ### Vendor Code Reuse Check (BLOCKING) For projects with vendor submodules (e.g., `vendor/` directory): 1. **Check every new file** against vendor for duplicates: ```bash # For each new file in src/lib/, check vendor find vendor -name "filename.ts" -type f ``` 2. **Flag as BLOCKING** if: - New file matches a vendor filename that could be imported - Code has "Ported from vendor" comment but vendor file has no Deno/Preact APIs - Vendor code uses dependencies that ARE available (check CLAUDE.md "Available Vendor Dependencies" table) 3. **Space-Lua is AVAILABLE** - If vendor code uses `LuaEnv`, `luaQuery`, `evalExpression`, etc., check if project already has Space-Lua aliases. If yes, the code should be imported, NOT ported. 4. **Ask these questions for every port:** - Did they try adding a path alias first? - Did they run `bun run build` to prove import fails? - What specific error prevents import? ## Review Priority 1. **Project instruction compliance** (CLAUDE.md, copilot-instructions.md) - Vendor reuse violations are BLOCKING 2. **Automated review check** (Copilot/CodeRabbit) - If found: use the `fx-dev:resolve-pr-feedback` skill to handle all automated feedback 3. **Code review**: bugs, security, performance ## Standards - APPROVE minor issues - BLOCK: security, bugs, **vendor reuse violations** - Ship good code, not perfect ## Output Format ``` **Decision**: APPROVE/REQUEST CHANGES **Size**: X lines [OK/EXCEEDS] **Automated Reviews**: NONE/DETECTED (Copilot/CodeRabbit) **Ready**: YES/NO ### Blocking - [Critical issues only] ### Suggestions - [Nice improvements] ### Next - [Clear actions] ``` Remember: Enable autonomous workflow with clear feedback.
Related in Code Review
gstack
IncludedFast headless browser for QA testing and site dogfooding. Navigate pages, interact with elements, verify state, diff before/after, take annotated screenshots, test responsive layouts, forms, uploads, dialogs, and capture bug evidence. Use when asked to open or test a site, verify a deployment, dogfood a user flow, or file a bug with screenshots. (gstack)
startup-due-diligence
IncludedLegal due diligence review for seed-stage and Series A startups (US, Delaware C-Corp focus). Supports both investor and founder perspectives. Capabilities include: (1) Interactive document review and issue spotting; (2) Document request list generation; (3) Cap table and SAFE/convertible note analysis; (4) Red flag identification with severity ratings; (5) Diligence report generation. TRIGGERS: due diligence, DD, startup investment, cap table review, Series A, seed round, investor diligence, legal review startup, SAFE analysis, convertible note, 409A, founder vesting.
interview-master
IncludedThis skill should be used when the user asks to "generate interview questions", "prepare for interview", "optimize resume", "conduct mock interview", "analyze git commits for resume", "generate resume from code", "review my resume", or mentions interview preparation, career assistance, or extracting project experience from git history. Provides comprehensive interview and career development guidance for both job seekers and interviewers.
fix-issue
IncludedFixes GitHub issues using parallel analysis agents for root cause investigation, code exploration, and regression detection. Reads issue context from gh CLI, searches codebase and memory for related patterns, generates a fix with tests, and links the resolution back to the issue via PR. Includes prevention analysis to avoid recurrence. Use when debugging errors, resolving regressions, fixing bugs, or triaging issues.
sf-apex
IncludedGenerates and reviews Salesforce Apex code with 150-point scoring. TRIGGER when: user writes, reviews, or fixes Apex classes, triggers, test classes, batch/queueable/schedulable jobs, or touches .cls/.trigger files. DO NOT TRIGGER when: LWC JavaScript (use sf-lwc), Flow XML (use sf-flow), SOQL-only queries (use sf-soql), or non-Salesforce code.
swift-development
IncludedComprehensive Swift development for building, testing, and deploying iOS/macOS applications. Use when Claude needs to: (1) Build Swift packages or Xcode projects from command line, (2) Run tests with XCTest or Swift Testing framework, (3) Manage iOS simulators with simctl, (4) Handle code signing, provisioning profiles, and app distribution, (5) Format or lint Swift code with SwiftFormat/SwiftLint, (6) Work with Swift Package Manager (SPM), (7) Implement Swift 6 concurrency patterns (async/await, actors, Sendable), (8) Create SwiftUI views with MVVM architecture, (9) Set up Core Data or SwiftData persistence, or any other Swift/iOS/macOS development tasks.