python-code-review-and-linting
Ruff linting rules, security patterns, mypy type checking, and Python code review best practices. PROACTIVELY activate for: (1) Setting up Ruff linting, (2) Fixing security vulnerabilities, (3) Resolving mypy type errors, (4) Code review for anti-patterns, (5) Python best practices enforcement. Triggers: "ruff", "lint", "refactor", "security", "anti-pattern", "python review", "mypy", "type error"
What this skill does
# Python Code Review and Linting Skill
## Metadata (Tier 1)
**Keywords**: ruff, lint, refactor, security, anti-pattern, python review, mypy
**File Patterns**: *.py
**Modes**: code_review
---
## Instructions (Tier 2)
### Ruff Configuration
```toml
# pyproject.toml
[tool.ruff]
line-length = 100
[tool.ruff.lint]
select = ["E", "F", "B", "S", "I"]
ignore = ["E501"] # Line too long (handled by formatter)
[tool.ruff.format]
quote-style = "double"
```
### Critical Security Rules (S prefix)
**S101**: Assert used (disabled in production)
```python
# Insecure
assert user.is_admin, "Not admin" # Can be disabled with -O flag
# Secure
if not user.is_admin:
raise PermissionError("Not admin")
```
**S105/S106**: Hardcoded secrets
```python
# Violation
password = "admin123"
# Fix
import os
password = os.getenv("PASSWORD")
```
**S301**: Unsafe pickle
```python
# Code execution risk
data = pickle.loads(user_input)
# Safe
import json
data = json.loads(user_input)
```
**S307**: Use of eval
```python
# Arbitrary code execution
result = eval(user_input)
# Safe
import ast
result = ast.literal_eval(user_input) # Only literals
```
### Common Anti-Patterns (B prefix)
**B006**: Mutable default argument
```python
# Shared state bug
def add_item(item, items=[]):
items.append(item)
return items
# Fix
def add_item(item, items=None):
if items is None:
items = []
items.append(item)
return items
```
**B007**: Unused loop variable
```python
# Confusing
for i in range(10):
do_something() # 'i' not used
# Clear
for _ in range(10):
do_something()
```
### mypy Type Errors
```python
# error: Argument 1 has incompatible type "str"; expected "int"
def process(x: int) -> int:
return x * 2
process("5") # Type error
# Fix
process(int("5"))
```
### Anti-Patterns
- Ignoring lint errors with # noqa
- Using basic exceptions (Exception, BaseException)
- Star imports (from module import *)
- Bare except clauses
Related in Security
mac-ops
IncludedComprehensive macOS workstation operations — diagnose kernel panics, identify failing drives, audit launchd startup items, decode wake reasons, triage TCC permission denials, manage APFS snapshots, recover from no-boot. Use for: Mac is slow, slow bootup, won't boot, kernel panic, kernel_task hot, mds_stores CPU, photoanalysisd, cloudd, login loop, gray screen, sleep wake failure, drive failing, IO errors, APFS snapshots eating space, Time Machine local snapshots, Spotlight indexing, launchd, LaunchAgent, LaunchDaemon, login items, TCC permissions, Full Disk Access, Screen Recording denied, Gatekeeper, quarantine, com.apple.quarantine, app is damaged, helper tool, /Library/PrivilegedHelperTools, pmset, wake reasons, dark wake, sysdiagnose, panic.ips, DiagnosticReports, configuration profile, MDM profile, remote diagnostics over SSH.
a11y-audit
IncludedRun accessibility audits on web projects combining automated scanning (axe-core, Lighthouse) with WCAG 2.1 AA compliance mapping, manual check guidance, and structured reporting. Output is configurable: markdown report only, markdown plus machine-readable JSON, or markdown plus issue tracker integration. Use this skill whenever the user mentions "accessibility audit", "a11y audit", "WCAG audit", "accessibility check", "compliance scan", or asks to check a web project for accessibility issues. Also trigger when the user wants to verify WCAG conformance or map findings to a specific standard (CAN-ASC-6.2, EN 301 549, ADA/AODA).
erpclaw
IncludedAI-native ERP system with self-extending OS. Full accounting, invoicing, inventory, purchasing, tax, billing, HR, payroll, advanced accounting (ASC 606/842, intercompany, consolidation), and financial reporting. 413 actions across 14 domains, 43 expansion modules. Constitutional guardrails, adversarial audit, schema migration. Double-entry GL, immutable audit trail, US GAAP.
assess
IncludedAssesses and rates quality 0-10 across multiple dimensions (correctness, maintainability, security, performance, testability, simplicity) with pros/cons analysis. Compares against project conventions and prior decisions from memory. Produces structured evaluation reports with actionable improvement suggestions. Use when evaluating code, designs, architectures, or comparing alternative approaches.
spring-boot-security-jwt
IncludedProvides JWT authentication and authorization patterns for Spring Boot 3.5.x covering token generation with JJWT, Bearer/cookie authentication, database/OAuth2 integration, and RBAC/permission-based access control using Spring Security 6.x. Use when implementing authentication or authorization in Spring Boot applications.
code-hardcode-audit
IncludedDetect hardcoded values, magic numbers, and leaked secrets. TRIGGERS - hardcode audit, magic numbers, PLR2004, secret scanning.