review-skill
Reviews PRs that add or modify Agent Skills, checking structural validity, design quality, and marketplace consistency. Use when reviewing skill file changes, auditing SKILL.md quality, or running automated skill PR reviews.
What this skill does
# Skill Review Review Agent Skill PRs for structural validity, design quality, and marketplace consistency. ## Arguments - `$ARGUMENTS`: Output file path for review results (required, passed by the calling harness or the user) - `--base <branch>`: Base branch for diff comparison (default: `main`) ## Workflow ### Step 1: Parse Arguments Extract the output path from `$ARGUMENTS`. If no path is provided, default to `.review-output.md`. Extract `--base` if provided, otherwise default to `main`. ### Step 2: Identify Changed Skills ```bash git diff --name-only $(git merge-base HEAD <base>)..<HEAD> | grep -E '(SKILL\.md|skills/[^/]+/)' ``` Group changed files by skill directory. Each unique skill directory is a review target. If no skill files changed, write "No skill files changed" to the output path and stop. ### Step 3: Read Each Changed Skill End-to-End For each changed skill: 1. Read the full `SKILL.md` (not just diff lines) 2. Read all files in the skill directory (references, scripts) 3. Note the parent plugin directory and locate its `plugin.json` ### Step 4: Run Structural Checks (HIGH Confidence) Apply every check in [references/structural-checks.md](references/structural-checks.md). These are binary pass/fail — violations are clear-cut. Structural violations are HIGH confidence because they can be verified mechanically. ### Step 5: Run Design Checks (MEDIUM Confidence) Apply every check in [references/design-checks.md](references/design-checks.md). These require judgment — flag only when the issue is clear, not when the approach is merely different from what you'd choose. Design issues are MEDIUM confidence because they involve subjective assessment. ### Step 6: Run Marketplace Checks (HIGH Confidence) Apply every check in [references/marketplace-checks.md](references/marketplace-checks.md). These verify the skill integrates correctly with the marketplace it belongs to. Marketplace violations are HIGH confidence because they can be verified by reading manifest files. ### Step 7: Load and Apply Verification Protocol Load the [review-verification-protocol](../review-verification-protocol/SKILL.md) skill. Before reporting any finding, verify: 1. You read the actual skill content, not just the diff context 2. The issue is real, not a style preference 3. The issue applies to skill files specifically (not general code review concerns) 4. You can point to the specific line that proves the issue Remove any finding you cannot verify. ### Step 8: Write Output Write all findings to the output path specified in Step 1, using the exact format below. ## Output Format ```markdown ## Review Summary [1-2 sentence overview of findings across all reviewed skills] ## Issues ### Critical (Blocking) 1. [FILE:LINE] ISSUE_TITLE - Issue: Description of what's wrong - Why: Why this matters for skill quality or marketplace health - Fix: Specific recommended fix - Confidence: HIGH ### Major (Should Fix) N. [FILE:LINE] ISSUE_TITLE - Issue: ... - Why: ... - Fix: ... - Confidence: HIGH|MEDIUM ### Minor (Nice to Have) N. [FILE:LINE] ISSUE_TITLE - Issue: ... - Why: ... - Fix: ... - Confidence: HIGH|MEDIUM ### Informational (For Awareness) N. [FILE:LINE] SUGGESTION_TITLE - Suggestion: ... - Rationale: ... - Confidence: MEDIUM ## Verdict Ready: Yes | No | With fixes 1-N Rationale: [1-2 sentences — only Critical and Major items block approval] ``` Every issue gets a sequential number. Every issue includes `Confidence: HIGH|MEDIUM`. The Verdict ignores Minor and Informational items. ## Severity Calibration ### Critical (Block Merge) - Invalid or missing YAML frontmatter (skill won't load) - Missing required `name` or `description` field - SKILL.md exceeds 500 lines (performance degradation) - Name collision with existing skill in the marketplace ### Major (Should Fix) - `name` violates format rules (not kebab-case, too long, reserved word) - `description` missing "what" or "when" component, wrong person, or exceeds 1024 chars - Nested reference chains (references that reference other references) - Description too vague to trigger accurately - Structured output with no format template or example - Windows-style paths in file references ### Minor (Nice to Have) - Time-sensitive content (hardcoded dates, "recently", "new") - Inconsistent terminology across skill files - Progressive disclosure not used when SKILL.md is dense - Workflows missing validation steps - Missing cross-reference (SKILL.md links to file that doesn't exist) ### Informational (For Awareness) - Trigger keyword overlap with existing marketplace skills - Suggestions for additional reference files - Opportunities to improve description specificity - Script lacks `--help` or uses interactive prompts ## Re-Review Rules On subsequent review passes after fixes are applied: 1. ONLY verify that previously flagged issues were addressed correctly 2. Do NOT introduce new findings unrelated to previous issues 3. Accept Minor items that weren't fixed — do not re-flag 4. The goal of re-review is verification, not discovery ## References - **Structural checks**: [references/structural-checks.md](references/structural-checks.md) — frontmatter, naming, line limits, path format - **Design checks**: [references/design-checks.md](references/design-checks.md) — description quality, progressive disclosure, degrees of freedom - **Marketplace checks**: [references/marketplace-checks.md](references/marketplace-checks.md) — name collision, plugin.json consistency, trigger overlap
Related in Design
contribute
IncludedLocal-only OSS contribution command center. Auto-refreshes the user's in-flight PR and issue state on invoke so conversations start with full context — no need to brief Claude on what's in flight. Helps the user find issues to contribute to on GitHub, builds per-repo dossiers of what each upstream expects (CLA, DCO, branch convention, AI policy, draft-first, review bots, issue templates), runs deterministic gates before any external action so AI-assisted contributions don't reach maintainers as slop. State is markdown-only: candidate files at ~/.contribute-system/candidates/, repo dossiers at ~/.contribute-system/research/, append-only event log at ~/.contribute-system/log.jsonl. No database, no cloud calls. Use when the user asks about their PRs / issues / contributions, wants to find new work to take on, claim an issue, build/refresh a repo's dossier, or draft a Design Issue or PR. Trigger with "/contribute", "what's my PR status", "find a contribution", "claim issue X", "draft a Design Issue for Y", "refresh dossier for Z".
architectural-analysis
IncludedUser-triggered deep architectural analysis of a codebase or scoped subtree across eight modes — information architecture, data flow, integration points, UI surfaces, interaction patterns, data model, control flow, and failure modes. This skill should be used when the user asks to "diagram this codebase," "map the architecture," "show the data flow," "give me an ERD," "trace control flow," "find the integration points," "verify the layout pattern," "audit the UX architecture," or any similar request whose primary deliverable is mermaid diagrams plus cited reports under docs/architecture/. Dispatches haiku/sonnet sub-agents in parallel for per-mode exploration, then verifies every citation mechanically before any node lands in a diagram. Not for one-off prose explanations of code (use code-explanation) or for high-level system design from scratch (use system-design).
mcp
IncludedModel Context Protocol (MCP) server development and tool management. Languages: Python, TypeScript. Capabilities: build MCP servers, integrate external APIs, discover/execute MCP tools, manage multi-server configs, design agent-centric tools. Actions: create, build, integrate, discover, execute, configure MCP servers/tools. Keywords: MCP, Model Context Protocol, MCP server, MCP tool, stdio transport, SSE transport, tool discovery, resource provider, prompt template, external API integration, Gemini CLI MCP, Claude MCP, agent tools, tool execution, server config. Use when: building MCP servers, integrating external APIs as MCP tools, discovering available MCP tools, executing MCP capabilities, configuring multi-server setups, designing tools for AI agents.
react-native-skia
IncludedDesign, build, debug, and optimise high-polish animated graphics in React Native or Expo using @shopify/react-native-skia, Reanimated, and Gesture Handler. Use when the user wants canvas-driven UI, shaders, paths, rich text, image filters, sprite fields, Skottie, video frames, snapshots, web CanvasKit setup, or performance tuning for custom motion-heavy elements such as loaders, hero art, cards, charts, progress indicators, particle systems, or gesture-driven surfaces. Also use when the user asks for fluid, glow, glass, blob, parallax, 60fps/120fps, or GPU-friendly animated effects in React Native, even if they do not explicitly say "Skia". Do not use for ordinary form/layout work with standard views.
plaid
IncludedProduct Led AI Development — guides founders from idea to launched product. Six capabilities: Idea (discover a product idea), Validate (pressure-test the idea against fatal flaws, problem reality, competition, and 2-week MVP feasibility), Plan (vision intake + document generation), Design (translate image references into a design.md spec), Launch (go-to-market strategy), and Build (roadmap execution). Use when someone says "PLAID", "plaid idea", "help me find an idea", "product idea", "idea from my business", "idea from my expertise", "plaid validate", "validate my idea", "pressure-test", "is this idea good", "find fatal flaws", "validate the problem", "plan a product", "define my vision", "generate a PRD", "product strategy", "plaid design", "design from image", "translate image to design", "create design.md", "extract design tokens", "plaid launch", "go-to-market", "launch plan", "GTM strategy", "launch playbook", "plaid build", "build the app", "start building", or "execute the roadmap".
nextjs-framer-motion-animations
IncludedAdds production-safe Motion for React or Framer Motion animations to Next.js apps, including reveal, hover and tap micro-interactions, whileInView, stagger, AnimatePresence, layout and layoutId transitions, reorder, scroll-linked UI, and lightweight route-content transitions. Use when the user asks to add, refactor, or debug Motion or Framer Motion in App Router or Pages Router codebases, especially around server/client boundaries, reduced motion, LazyMotion, bundle size, hydration, or route transitions. Avoid for GSAP-style timelines, WebGL or 3D scenes, heavy scroll storytelling, or CSS-only effects unless Motion is explicitly requested.