reviewing-changes
Android-specific code review workflow additions for Bitwarden Android. Provides change type refinements, checklist loading, and reference material organization. Complements bitwarden-code-reviewer agent's base review standards.
What this skill does
# Reviewing Changes - Android Additions This skill provides Android-specific workflow additions that complement the base `bitwarden-code-reviewer` agent standards. ## Instructions **IMPORTANT**: Use structured thinking throughout your review process. Plan your analysis in `<thinking>` tags before providing final feedback. ### Step 1: Retrieve Additional Details <thinking> Determine if more context is available for the changes: 1. Are there JIRA tickets or GitHub Issues mentioned in the PR title or body? 2. Are there other GitHub pull requests mentioned in the PR title or body? </thinking> Retrieve any additional information linked to the pull request using available tools (JIRA MCP, GitHub API). If pull request title and message do not provide enough context, request additional details from the reviewer: - Link a JIRA ticket - Associate a GitHub issue - Link to another pull request - Add more detail to the PR title or body ### Step 2: Detect Change Type with Android Refinements <thinking> Analyze the changeset systematically: 1. What files were modified? (code vs config vs docs) 2. What is the PR/commit title indicating? 3. Is there new functionality or just modifications? 4. What's the risk level of these changes? </thinking> Use the base change type detection from the agent, with Android-specific refinements: **Android-specific patterns:** - **Feature Addition**: New `ViewModel`, new `Repository`, new `@Composable` functions, new `*Screen.kt` files - **UI Refinement**: Changes only in `*Screen.kt`, `*Composable.kt`, `ui/` package files - **Infrastructure**: Changes to `.github/workflows/`, `gradle/`, `build.gradle.kts`, `libs.versions.toml` - **Dependency Update**: Changes only to `libs.versions.toml` or `build.gradle.kts` with version bumps ### Step 3: Load Appropriate Checklist Based on detected type, read the relevant checklist file: - **Dependency Update** → `checklists/dependency-update.md` (expedited review) - **Bug Fix** → `checklists/bug-fix.md` (focused review) - **Feature Addition** → `checklists/feature-addition.md` (comprehensive review) - **UI Refinement** → `checklists/ui-refinement.md` (design-focused review) - **Refactoring** → `checklists/refactoring.md` (pattern-focused review) - **Infrastructure** → `checklists/infrastructure.md` (tooling-focused review) The checklist provides: - Multi-pass review strategy - Type-specific focus areas - What to check and what to skip - Structured thinking guidance ### Step 4: Execute Review Following Checklist <thinking> Before diving into details: 1. What are the highest-risk areas of this change? 2. Which architectural patterns need verification? 3. What security implications exist? 4. How should I prioritize my findings? 5. What tone is appropriate for this feedback? </thinking> Follow the checklist's multi-pass strategy, thinking through each pass systematically. ### Step 5: Consult Android Reference Materials As Needed Load reference files only when needed for specific questions: - **Issue prioritization** → `reference/priority-framework.md` (Critical vs Suggested vs Optional) - **Phrasing feedback** → `reference/review-psychology.md` (questions vs commands, I-statements) - **Architecture questions** → `reference/architectural-patterns.md` (MVVM, Hilt DI, module org, error handling) - **Security questions (quick reference)** → `reference/security-patterns.md` (common patterns and anti-patterns) - **Security questions (comprehensive)** → `docs/ARCHITECTURE.md#security` (full zero-knowledge architecture) - **Testing questions** → `reference/testing-patterns.md` (unit tests, mocking, null safety) - **UI questions** → `reference/ui-patterns.md` (Compose patterns, theming) - **Style questions** → `docs/STYLE_AND_BEST_PRACTICES.md` ## Core Principles - **Appropriate depth**: Match review rigor to change complexity and risk - **Specific references**: Always use `file:line_number` format for precise location - **Actionable feedback**: Say what to do and why, not just what's wrong - **Efficient reviews**: Use multi-pass strategy, skip what's not relevant - **Android patterns**: Validate MVVM, Hilt DI, Compose conventions, Kotlin idioms
Related in AI Agents
skill-development
IncludedComprehensive meta-skill for creating, managing, validating, auditing, and distributing Claude Code skills and slash commands (unified in v2.1.3+). Provides skill templates, creation workflows, validation patterns, audit checklists, naming conventions, YAML frontmatter guidance, progressive disclosure examples, and best practices lookup. Use when creating new skills, validating existing skills, auditing skill quality, understanding skill architecture, needing skill templates, learning about YAML frontmatter requirements, progressive disclosure patterns, tool restrictions (allowed-tools), skill composition, skill naming conventions, troubleshooting skill activation issues, creating custom slash commands, configuring command frontmatter, using command arguments ($ARGUMENTS, $1, $2), bash execution in commands, file references in commands, command namespacing, plugin commands, MCP slash commands, Skill tool configuration, or deciding between skills vs slash commands. Delegates to docs-management skill for official documentation.
reprompter
IncludedTransform messy prompts into well-structured, effective prompts — single or multi-agent. Use when: "reprompt", "reprompt this", "clean up this prompt", "structure my prompt", rough text needing XML tags and best practices, "reprompter teams", "repromptception", "run with quality", "smart run", "smart agents", multi-agent tasks, audits, parallel work, anything going to agent teams. Don't use when: simple Q&A, pure chat, immediate execution-only tasks. See "Don't Use When" section for details. Outputs: Structured XML/Markdown prompt, quality score (before/after), optional team brief + per-agent sub-prompts, agent team output files. Success criteria: Single mode quality score ≥ 7/10; Repromptception per-agent prompt quality score 8+/10; all required sections present, actionable and specific.
adaptive-compaction
IncludedAdaptive add-on policy and recovery layer that decides WHEN to compact, prune, snapshot, or fork -- replacing fixed-percent auto-compaction across Claude Code, Codex, and MCP-capable hosts. Trigger on auto-compact timing or damage: "when should I compact", "is it safe to compact now or start a fresh session", "auto-compact fires too early/mid-task", "switching to an unrelated task but the window still has space", "context rot", "answers get worse the longer the session runs", "the agent forgot the plan or my decisions after it summarized", "add a layer on top that manages context without changing the agent", raising autoCompactWindow to give the policy room, or installing/tuning a cross-tool compaction policy or PreCompact hook -- even when "compaction" is never said but the problem is context-window pressure or post-summarization memory loss. Do NOT use to summarize a conversation, build RAG, write a summarization prompt (decides WHEN not HOW), or answer max-context-length trivia.
agent-skill-creator
IncludedCreate cross-platform agent skills from workflow descriptions. Activates when users ask to create an agent, automate a repetitive workflow, create a custom skill, or need advanced agent creation. Triggers on phrases like create agent for, automate workflow, create skill for, every day I have to, daily I need to, turn process into agent, need to automate, create a cross-platform skill, validate this skill, export this skill, migrate this skill. Supports single skills, multi-agent suites, transcript processing, template-based creation, interactive configuration, cross-platform export, and spec validation.
llm-wiki
IncludedUse when building or maintaining a persistent personal knowledge base (second brain) in Obsidian where an LLM incrementally ingests sources, updates entity/concept pages, maintains cross-references, and keeps a synthesis current. Triggers include "second brain", "Obsidian wiki", "personal knowledge management", "ingest this paper/article/book", "build a research wiki", "compound knowledge", "Memex", or whenever the user wants knowledge to accumulate across sessions instead of being re-derived by RAG on every query.
skill-master
IncludedAgent Skills authoring, evaluation, and optimization. Create, edit, validate, benchmark, and improve skills following the agentskills.io specification. Use when designing SKILL.md files, structuring skill folders (references, scripts, assets), ingesting external documentation into skills, running trigger evals, benchmarking skill quality, optimizing descriptions, or performing blind A/B comparisons. Keywords: agentskills.io, SKILL.md, skill authoring, eval, benchmark, trigger optimization.