reviewing-pull-requests
This skill should be used when the user asks to "review my PR", "check my code before merging", "run a PR review", "analyze this pull request", "review my changes", or needs a comprehensive multi-agent pull request review covering code quality, test coverage, error handling, type design, comments, and code simplification.
What this skill does
# Comprehensive PR Review Workflow Run multi-agent pull request reviews where each specialized agent focuses on a different aspect of code quality, then aggregate results into an actionable summary. ## Review Aspects Six specialized review agents are available: | Agent | Focus | When Applicable | |-------|-------|-----------------| | **code-reviewer** | CLAUDE.md compliance, bugs, general quality | Always | | **pr-test-analyzer** | Test coverage quality, critical gaps | Test files changed | | **silent-failure-hunter** | Silent failures, catch blocks, error logging | Error handling changed | | **type-design-analyzer** | Type encapsulation, invariant expression | New types added/modified | | **comment-analyzer** | Comment accuracy, documentation completeness | Comments/docs added | | **code-simplifier** | Code clarity, readability, project standards | After passing review | ## Review Workflow ### Step 1: Determine Review Scope 1. Check git status to identify changed files: `git diff --name-only` 2. Check if a PR already exists: `gh pr view` 3. Parse any user-specified review aspects 4. Default: run all applicable reviews ### Step 2: Identify Applicable Reviews Based on the changes: - **Always applicable**: code-reviewer (general quality) - **If test files changed**: pr-test-analyzer - **If comments/docs added**: comment-analyzer - **If error handling changed**: silent-failure-hunter - **If types added/modified**: type-design-analyzer - **After passing review**: code-simplifier (polish and refine) ### Step 3: Launch Review Agents **Sequential approach** (default): - One agent at a time for easier understanding and action - Each report is complete before the next - Good for interactive review **Parallel approach** (on user request): - Launch all agents simultaneously - Faster for comprehensive review - Results come back together ### Step 4: Aggregate Results After agents complete, organize findings: ```markdown # PR Review Summary ## Critical Issues (X found) - [agent-name]: Issue description [file:line] ## Important Issues (X found) - [agent-name]: Issue description [file:line] ## Suggestions (X found) - [agent-name]: Suggestion [file:line] ## Strengths - What's well-done in this PR ## Recommended Action 1. Fix critical issues first 2. Address important issues 3. Consider suggestions 4. Re-run review after fixes ``` ## Agent Details ### code-reviewer Reviews code against project guidelines in CLAUDE.md with confidence-based filtering (only reports issues with confidence >= 80). Checks for CLAUDE.md compliance, bug detection, and code quality. Groups issues by severity (Critical: 90-100, Important: 80-89). ### pr-test-analyzer Focuses on behavioral coverage rather than line coverage. Identifies critical code paths, edge cases, and error conditions that must be tested. Rates criticality from 1-10 and maps to severity (9-10: CRITICAL, 7-8: HIGH, 5-6: MEDIUM, 1-4: LOW). ### silent-failure-hunter Analyzes for silent failures, empty catch blocks, broad exception catching, inadequate error messages, and unjustified fallback behavior. Checks logging quality, user feedback, catch block specificity, and error propagation. ### type-design-analyzer Evaluates new types on four dimensions (each rated 1-10): encapsulation, invariant expression, invariant usefulness, and invariant enforcement. Flags anti-patterns like anemic domain models, exposed mutable internals, and missing construction validation. ### comment-analyzer Verifies comment factual accuracy against code, assesses completeness, evaluates long-term value, and identifies misleading elements. Categorizes findings as critical issues, improvement opportunities, and recommended removals. ### code-simplifier Simplifies code for clarity and maintainability while preserving all functionality. Applies project standards, reduces unnecessary complexity, eliminates redundant code, and improves naming. Avoids nested ternaries and over-compact solutions. ## Usage Patterns **Full review (default):** Run all applicable review agents based on changed files. **Targeted review:** Specify aspects to focus on: `tests`, `errors`, `comments`, `types`, `code`, `simplify`. **Parallel review:** Request all agents run simultaneously for faster results. ## Workflow Integration **Before committing:** 1. Write code 2. Run code and error reviews 3. Fix critical issues 4. Commit **Before creating PR:** 1. Stage all changes 2. Run all reviews 3. Address critical and important issues 4. Re-run specific reviews to verify 5. Create PR **After PR feedback:** 1. Make requested changes 2. Run targeted reviews based on feedback 3. Verify issues are resolved 4. Push updates ## Tips - Run reviews early, before creating the PR - Agents analyze git diff by default - Address critical issues before lower priority ones - Re-run reviews after fixes to verify resolution - Use targeted reviews when the concern area is known - All agents return actionable results with specific file:line references
Related in Design
contribute
IncludedLocal-only OSS contribution command center. Auto-refreshes the user's in-flight PR and issue state on invoke so conversations start with full context — no need to brief Claude on what's in flight. Helps the user find issues to contribute to on GitHub, builds per-repo dossiers of what each upstream expects (CLA, DCO, branch convention, AI policy, draft-first, review bots, issue templates), runs deterministic gates before any external action so AI-assisted contributions don't reach maintainers as slop. State is markdown-only: candidate files at ~/.contribute-system/candidates/, repo dossiers at ~/.contribute-system/research/, append-only event log at ~/.contribute-system/log.jsonl. No database, no cloud calls. Use when the user asks about their PRs / issues / contributions, wants to find new work to take on, claim an issue, build/refresh a repo's dossier, or draft a Design Issue or PR. Trigger with "/contribute", "what's my PR status", "find a contribution", "claim issue X", "draft a Design Issue for Y", "refresh dossier for Z".
architectural-analysis
IncludedUser-triggered deep architectural analysis of a codebase or scoped subtree across eight modes — information architecture, data flow, integration points, UI surfaces, interaction patterns, data model, control flow, and failure modes. This skill should be used when the user asks to "diagram this codebase," "map the architecture," "show the data flow," "give me an ERD," "trace control flow," "find the integration points," "verify the layout pattern," "audit the UX architecture," or any similar request whose primary deliverable is mermaid diagrams plus cited reports under docs/architecture/. Dispatches haiku/sonnet sub-agents in parallel for per-mode exploration, then verifies every citation mechanically before any node lands in a diagram. Not for one-off prose explanations of code (use code-explanation) or for high-level system design from scratch (use system-design).
mcp
IncludedModel Context Protocol (MCP) server development and tool management. Languages: Python, TypeScript. Capabilities: build MCP servers, integrate external APIs, discover/execute MCP tools, manage multi-server configs, design agent-centric tools. Actions: create, build, integrate, discover, execute, configure MCP servers/tools. Keywords: MCP, Model Context Protocol, MCP server, MCP tool, stdio transport, SSE transport, tool discovery, resource provider, prompt template, external API integration, Gemini CLI MCP, Claude MCP, agent tools, tool execution, server config. Use when: building MCP servers, integrating external APIs as MCP tools, discovering available MCP tools, executing MCP capabilities, configuring multi-server setups, designing tools for AI agents.
react-native-skia
IncludedDesign, build, debug, and optimise high-polish animated graphics in React Native or Expo using @shopify/react-native-skia, Reanimated, and Gesture Handler. Use when the user wants canvas-driven UI, shaders, paths, rich text, image filters, sprite fields, Skottie, video frames, snapshots, web CanvasKit setup, or performance tuning for custom motion-heavy elements such as loaders, hero art, cards, charts, progress indicators, particle systems, or gesture-driven surfaces. Also use when the user asks for fluid, glow, glass, blob, parallax, 60fps/120fps, or GPU-friendly animated effects in React Native, even if they do not explicitly say "Skia". Do not use for ordinary form/layout work with standard views.
plaid
IncludedProduct Led AI Development — guides founders from idea to launched product. Six capabilities: Idea (discover a product idea), Validate (pressure-test the idea against fatal flaws, problem reality, competition, and 2-week MVP feasibility), Plan (vision intake + document generation), Design (translate image references into a design.md spec), Launch (go-to-market strategy), and Build (roadmap execution). Use when someone says "PLAID", "plaid idea", "help me find an idea", "product idea", "idea from my business", "idea from my expertise", "plaid validate", "validate my idea", "pressure-test", "is this idea good", "find fatal flaws", "validate the problem", "plan a product", "define my vision", "generate a PRD", "product strategy", "plaid design", "design from image", "translate image to design", "create design.md", "extract design tokens", "plaid launch", "go-to-market", "launch plan", "GTM strategy", "launch playbook", "plaid build", "build the app", "start building", or "execute the roadmap".
nextjs-framer-motion-animations
IncludedAdds production-safe Motion for React or Framer Motion animations to Next.js apps, including reveal, hover and tap micro-interactions, whileInView, stagger, AnimatePresence, layout and layoutId transitions, reorder, scroll-linked UI, and lightweight route-content transitions. Use when the user asks to add, refactor, or debug Motion or Framer Motion in App Router or Pages Router codebases, especially around server/client boundaries, reduced motion, LazyMotion, bundle size, hydration, or route transitions. Avoid for GSAP-style timelines, WebGL or 3D scenes, heavy scroll storytelling, or CSS-only effects unless Motion is explicitly requested.