rust-quality
Rust code quality audit based on Apollo best practices
What this skill does
## Target
$ARGUMENTS
---
Audit Rust code quality. Report issues in organized format, then offer to fix.
## Audit Categories
### 1. Clippy Violations
- All clippy warnings must be addressed, not silenced
- Use `#[expect(...)]` with comment if truly necessary, never bare `#[allow(...)]`
- Check for missing workspace lint config in Cargo.toml
### 2. Borrowing & Cloning
**Red flags:**
- `.clone()` inside loops - use `.cloned()` or `.copied()` on iterator
- `.clone()` on large types (`Vec<T>`, `HashMap<K,V>`)
- Clone when borrow would work - `fn process(s: String)` vs `fn process(s: &str)`
- `&Vec<T>` instead of `&[T]`
- `&String` instead of `&str`
- Cloning reference args when caller should pass ownership
**Prefer:**
- Borrow over clone
- `&str` over `String` in params
- `&[T]` over `&Vec<T>` in params
- `impl AsRef<T>` for flexible APIs
### 3. Option/Result Handling
**Red flags:**
- `.unwrap()` or `.expect()` in non-test code
- `match` for simple Ok/Err -> Some/None conversions (use `.ok()`, `.ok_or()`)
- Manual match that could be `let Ok(x) = expr else { return }`
- `if let Some(x) = ... { x } else { default }` instead of `.unwrap_or()`
**Prefer:**
- `?` for error propagation
- `let Ok(x) = expr else { return Err(...) }` for early returns
- `.ok_or_else()` / `.map_or_else()` when allocation needed
- `thiserror` for library errors, `anyhow` only for binaries
### 4. Iterator Patterns
**Red flags:**
- Collecting just to iterate again - `.collect::<Vec<_>>()` then `for x in vec`
- Manual loops that could be `.filter().map().collect()`
- `.fold()` for simple sums (use `.sum()`)
- Missing `.iter()` vs `.into_iter()` awareness (prefer `.iter()` for `Copy` types)
**Prefer:**
- Pass iterators directly when possible
- Lazy evaluation - don't collect until needed
- `.enumerate()` over manual index tracking
### 5. Error Handling
**Red flags:**
- `panic!` in library code (use `Result`)
- `Box<dyn Error>` in library APIs (use `thiserror`)
- Missing `# Errors` doc section on fallible functions
- `anyhow` in library code
**Prefer:**
- `thiserror` with descriptive error variants
- Error hierarchies with `#[from]` for wrapping
- `?` over verbose match chains
- `inspect_err()` for logging
### 6. Performance Anti-patterns
**Red flags:**
- Unnecessary heap allocation (`Box` when stack works)
- `#[inline]` without benchmark proof
- Large stack allocations (arrays > 64KB)
- `Box<dyn Trait>` when `impl Trait` works
- Early allocation in `or`, `map_or`, `unwrap_or` (use `_else` variants)
**Prefer:**
- `impl Trait` (static dispatch) over `dyn Trait` when possible
- `Cow<'_, str>` for maybe-owned data
- Benchmark before optimizing
### 7. Comments & Documentation
**Red flags:**
- Comments explaining "what" not "why"
- `// TODO` without issue link
- Stale/misleading comments
- Missing `///` docs on public items
- Missing `# Examples`, `# Errors`, `# Panics` sections
**Prefer:**
- Let code speak - extract functions over comments
- Link to ADRs/issues for context
- Doc tests as living examples
### 8. Type System
**Red flags:**
- Runtime state checks that could be compile-time (type state pattern)
- `Option<T>` fields for required builder params
- Missing `#[non_exhaustive]` on public enums
- `dyn Trait` without `Send + Sync` in async contexts
**Prefer:**
- Type state pattern for state machines
- Compile-time guarantees over runtime checks
- `PhantomData` for zero-cost type markers
### 9. Rust Slop (AI/verbose cruft)
**Red flags:**
- Defensive code for impossible cases
- Over-engineered abstractions for one-time use
- Verbose intermediate variables adding nothing
- Interfaces with single implementations
- Factory patterns for simple construction
## Output Format
```
# Rust Quality Audit: [path]
## Critical (must fix)
- [file:line] Category: Description
## Warnings (should fix)
- [file:line] Category: Description
## Suggestions (consider)
- [file:line] Category: Description
## Summary
- X critical, Y warnings, Z suggestions
- Key patterns to address: ...
```
After reporting, ask: "Fix issues? (all / critical only / skip)"
Related in Backend & APIs
jfrog
IncludedInteract with the JFrog Platform via the JFrog CLI and REST/GraphQL APIs. Use this skill when the user wants to manage Artifactory repositories, upload or download artifacts, manage builds, configure permissions, manage users and groups, work with access tokens, configure JFrog CLI servers, search artifacts, manage properties, set up replication, manage JFrog Projects, run security audits or scans, look up CVE details, query exposures scan results from JFrog Advanced Security, manage release bundles and lifecycle operations, aggregate or export platform data, or perform any JFrog Platform administration task. Also use when the user mentions jf, jfrog, artifactory, xray, distribution, evidence, apptrust, onemodel, graphql, workers, mission control, curation, advanced security, exposures, or any JFrog product name.
cupynumeric-migration-readiness
IncludedPre-migration readiness assessor for porting NumPy to cuPyNumeric. Use BEFORE substantial porting work begins when the user asks whether code will scale on GPU, whether they should migrate to cuPyNumeric, which NumPy patterns transfer cleanly, what must be refactored before porting, or mentions pre-port assessment, scaling analysis, or refactor planning. Inspect the user's source code, look up NumPy usage, cross-reference the cuPyNumeric API support manifest, and distinguish distributed-scaling-friendly patterns from blockers such as unsupported APIs, scalar synchronization, host round-trips, Python/object-heavy control flow, shape/data-dependent branching, and in-place mutation hazards. Produce a verdict of READY, LIGHT REFACTOR, SIGNIFICANT REFACTOR, or NOT RECOMMENDED, with concrete refactor pointers.
alibabacloud-data-agent-skill
IncludedInvoke Alibaba Cloud Apsara Data Agent for Analytics via CLI to perform natural language-driven data analysis on enterprise databases. Data Agent for Analytics is an intelligent data analysis agent developed by Alibaba Cloud Database team for enterprise users. It automatically completes requirement analysis, data understanding, analysis insights, and report generation based on natural language descriptions. This tool supports: discovering data resources (instances/databases/tables) managed in DMS, initiating query or deep analysis sessions, real-time progress tracking, and retrieving analysis conclusions and generated reports. Use this Skill when users need to query databases, analyze data trends, generate data reports, ask questions in natural language, or mention "Data Agent", "data analysis", "database query", "SQL analysis", "data insights".
token-optimizer
IncludedReduce OpenClaw token usage and API costs through smart model routing, heartbeat optimization, budget tracking, and native 2026.2.15 features (session pruning, bootstrap size limits, cache TTL alignment). Use when token costs are high, API rate limits are being hit, or hosting multiple agents at scale. The 4 executable scripts (context_optimizer, model_router, heartbeat_optimizer, token_tracker) are local-only — no network requests, no subprocess calls, no system modifications. Reference files (PROVIDERS.md, config-patches.json) document optional multi-provider strategies that require external API keys and network access if you choose to use them. See SECURITY.md for full breakdown.
resend-cli
IncludedUse this skill when the task is specifically about operating Resend from an AI agent, terminal session, or CI job via the official resend CLI: installing/authenticating the CLI, sending/listing/updating/cancelling emails, batch sends, domains and DNS, webhooks and local listeners, inbound receiving, contacts, topics, segments, broadcasts, templates, API keys, profiles, or debugging Resend CLI/API failures. Trigger on mentions of Resend CLI, `resend`, `resend doctor`, `resend emails send`, `resend domains`, `resend webhooks listen`, `resend emails receiving`, or agent-friendly terminal automation.
alibabacloud-odps-maxframe-coding
IncludedUse this skill for MaxFrame SDK development and documentation navigation on Alibaba Cloud MaxCompute (ODPS). Helps answer MaxFrame API, concept, official example, and supported pandas API questions; create data processing programs; read/write MaxCompute tables; debug jobs (remote or local); and build custom DPE runtime images. Trigger when users mention MaxFrame, MaxCompute with MaxFrame, ODPS table processing, DPE runtime, MaxFrame docs/examples, DataFrame/Tensor operations, or GPU runtime setup. Works for both English and Chinese queries about Alibaba Cloud data processing with MaxFrame.