shadcn-code-review
Reviews shadcn/ui components for CVA patterns, composition with asChild, accessibility states, and data-slot usage. Use when reviewing React components using shadcn/ui, Radix primitives, or Tailwind styling.
What this skill does
# shadcn/ui Code Review ## Quick Reference | Issue Type | Reference | |------------|-----------| | className in CVA, missing VariantProps, compound variants | [references/cva-patterns.md](references/cva-patterns.md) | | asChild without Slot, missing Context, component composition | [references/composition.md](references/composition.md) | | Missing focus-visible, aria-invalid, disabled states | [references/accessibility.md](references/accessibility.md) | | Missing data-slot, incorrect CSS targeting | [references/data-slot.md](references/data-slot.md) | ## Review Checklist - [ ] `cn()` receives className, not CVA variants - [ ] `VariantProps<typeof variants>` exported for consumers - [ ] Compound variants used for complex state combinations - [ ] `asChild` pattern uses `@radix-ui/react-slot` - [ ] Context used for component composition (Card, Accordion, etc.) - [ ] `focus-visible:` states, not just `:focus` - [ ] `aria-invalid`, `aria-disabled` for form states - [ ] `disabled:` variants for all interactive elements - [ ] `sr-only` for screen reader text - [ ] `data-slot` attributes for targetable composition parts - [ ] CSS uses `has()` selectors for state-based styling - [ ] No direct className overrides of variant styles ## Hard gates (before writing findings) Run these in order. **Do not draft user-facing findings until every gate passes** for the batch you are about to report. 1. **Location evidence** — **Pass:** Each issue lists a repo path and either a line range or a short verbatim quote from the file you read (not from memory or diff-only guesswork). 2. **Exemption check** — **Pass:** For each issue, you can state in one line why it is *not* covered by [Valid Patterns (Do NOT Flag)](#valid-patterns-do-not-flag). 3. **Context-sensitive claims** — **Pass:** For accessibility or Radix-related flags, you checked the file for imports/wrappers showing what actually runs (or you cite the concrete gap). 4. **Protocol** — **Pass:** You completed the Pre-Report Verification Checklist in [review-verification-protocol](../review-verification-protocol/SKILL.md) for this review. ## Valid Patterns (Do NOT Flag) These are correct patterns that should NOT be flagged as issues: - `max-h-(--var)` - correct Tailwind v4 CSS variable syntax (NOT v3 bracket notation) - `text-[color:var(--x)]` - valid arbitrary value syntax - Copying shadcn component code into project - intended usage pattern - Not documenting copied shadcn components - library internals, not custom code - Using cn() with many arguments - composition is the pattern - Conditional classes in cn() arrays - valid Tailwind pattern - Extending primitive components without additional docs - well-known base ## Context-Sensitive Rules Apply these rules with appropriate context awareness: - Flag accessibility issues ONLY IF not handled by Radix primitives underneath - Flag missing aria labels ONLY IF component isn't using accessible radix primitive - Flag variant proliferation ONLY IF variants could be composed from existing - Flag component documentation ONLY IF it's custom code, not copied shadcn ## Library Convention Note shadcn/ui components are designed to be copied and modified. Code review should focus on: - Custom modifications made to copied components - Integration with application state/data - Accessibility in custom usage contexts Do NOT flag: - Standard shadcn component internals - Radix primitive usage patterns - Default variant implementations ## When to Load References - Reviewing variant definitions → cva-patterns.md - Reviewing component composition with asChild → composition.md - Reviewing form components or interactive elements → accessibility.md - Reviewing multi-part components (Card, Select, etc.) → data-slot.md ## Review Questions 1. Are CVA variants properly separated from className props? 2. Does asChild composition work correctly with Slot? 3. Are all accessibility states (focus, invalid, disabled) handled? 4. Are data-slot attributes used for component part targeting? 5. Can consumers extend variants without breaking composition? ## Before Submitting Findings Complete [Hard gates](#hard-gates-before-writing-findings) (especially gate 4), then report only issues that still pass the [review-verification-protocol](../review-verification-protocol/SKILL.md) pre-report checks.
Related in Design
contribute
IncludedLocal-only OSS contribution command center. Auto-refreshes the user's in-flight PR and issue state on invoke so conversations start with full context — no need to brief Claude on what's in flight. Helps the user find issues to contribute to on GitHub, builds per-repo dossiers of what each upstream expects (CLA, DCO, branch convention, AI policy, draft-first, review bots, issue templates), runs deterministic gates before any external action so AI-assisted contributions don't reach maintainers as slop. State is markdown-only: candidate files at ~/.contribute-system/candidates/, repo dossiers at ~/.contribute-system/research/, append-only event log at ~/.contribute-system/log.jsonl. No database, no cloud calls. Use when the user asks about their PRs / issues / contributions, wants to find new work to take on, claim an issue, build/refresh a repo's dossier, or draft a Design Issue or PR. Trigger with "/contribute", "what's my PR status", "find a contribution", "claim issue X", "draft a Design Issue for Y", "refresh dossier for Z".
architectural-analysis
IncludedUser-triggered deep architectural analysis of a codebase or scoped subtree across eight modes — information architecture, data flow, integration points, UI surfaces, interaction patterns, data model, control flow, and failure modes. This skill should be used when the user asks to "diagram this codebase," "map the architecture," "show the data flow," "give me an ERD," "trace control flow," "find the integration points," "verify the layout pattern," "audit the UX architecture," or any similar request whose primary deliverable is mermaid diagrams plus cited reports under docs/architecture/. Dispatches haiku/sonnet sub-agents in parallel for per-mode exploration, then verifies every citation mechanically before any node lands in a diagram. Not for one-off prose explanations of code (use code-explanation) or for high-level system design from scratch (use system-design).
mcp
IncludedModel Context Protocol (MCP) server development and tool management. Languages: Python, TypeScript. Capabilities: build MCP servers, integrate external APIs, discover/execute MCP tools, manage multi-server configs, design agent-centric tools. Actions: create, build, integrate, discover, execute, configure MCP servers/tools. Keywords: MCP, Model Context Protocol, MCP server, MCP tool, stdio transport, SSE transport, tool discovery, resource provider, prompt template, external API integration, Gemini CLI MCP, Claude MCP, agent tools, tool execution, server config. Use when: building MCP servers, integrating external APIs as MCP tools, discovering available MCP tools, executing MCP capabilities, configuring multi-server setups, designing tools for AI agents.
react-native-skia
IncludedDesign, build, debug, and optimise high-polish animated graphics in React Native or Expo using @shopify/react-native-skia, Reanimated, and Gesture Handler. Use when the user wants canvas-driven UI, shaders, paths, rich text, image filters, sprite fields, Skottie, video frames, snapshots, web CanvasKit setup, or performance tuning for custom motion-heavy elements such as loaders, hero art, cards, charts, progress indicators, particle systems, or gesture-driven surfaces. Also use when the user asks for fluid, glow, glass, blob, parallax, 60fps/120fps, or GPU-friendly animated effects in React Native, even if they do not explicitly say "Skia". Do not use for ordinary form/layout work with standard views.
plaid
IncludedProduct Led AI Development — guides founders from idea to launched product. Six capabilities: Idea (discover a product idea), Validate (pressure-test the idea against fatal flaws, problem reality, competition, and 2-week MVP feasibility), Plan (vision intake + document generation), Design (translate image references into a design.md spec), Launch (go-to-market strategy), and Build (roadmap execution). Use when someone says "PLAID", "plaid idea", "help me find an idea", "product idea", "idea from my business", "idea from my expertise", "plaid validate", "validate my idea", "pressure-test", "is this idea good", "find fatal flaws", "validate the problem", "plan a product", "define my vision", "generate a PRD", "product strategy", "plaid design", "design from image", "translate image to design", "create design.md", "extract design tokens", "plaid launch", "go-to-market", "launch plan", "GTM strategy", "launch playbook", "plaid build", "build the app", "start building", or "execute the roadmap".
nextjs-framer-motion-animations
IncludedAdds production-safe Motion for React or Framer Motion animations to Next.js apps, including reveal, hover and tap micro-interactions, whileInView, stagger, AnimatePresence, layout and layoutId transitions, reorder, scroll-linked UI, and lightweight route-content transitions. Use when the user asks to add, refactor, or debug Motion or Framer Motion in App Router or Pages Router codebases, especially around server/client boundaries, reduced motion, LazyMotion, bundle size, hydration, or route transitions. Avoid for GSAP-style timelines, WebGL or 3D scenes, heavy scroll storytelling, or CSS-only effects unless Motion is explicitly requested.