skill-review-response
How to handle code review feedback — verify before implementing, push back when wrong, never agree blindly
What this skill does
> **Host: Codex CLI** — This skill was designed for Claude Code and adapted for Codex. > Cross-reference commands use installed skill names in Codex rather than `/octo:*` slash commands. > Use the active Codex shell and subagent tools. Do not claim a provider, model, or host subagent is available until the current session exposes it. > For host tool equivalents, see `skills/blocks/codex-host-adapter.md`. # Receiving Code Review ## Core Principle Code review requires technical evaluation, not performative agreement. **Never blindly implement review feedback.** Verify it's correct for THIS codebase before changing anything. ## The Response Pattern ``` WHEN receiving code review feedback: 1. READ — Complete feedback without reacting 2. RESTATE — Summarize the requirement in your own words 3. VERIFY — Check against actual codebase state 4. EVALUATE — Is this technically sound for THIS context? 5. RESPOND — Technical acknowledgment OR reasoned pushback 6. IMPLEMENT — One item at a time, verify each change ``` ## Forbidden Responses **NEVER say:** - "You're absolutely right!" (without verification) - "Great catch!" (before confirming it IS a catch) - "I'll fix that right away!" (before evaluating whether it needs fixing) - "Done!" (without running verification — see skill-verification-gate) **These are social performance, not technical evaluation.** They lead to: - Implementing wrong suggestions - Introducing bugs to "fix" non-issues - Wasting time on style preferences disguised as bugs ## Evaluation Checklist For each piece of feedback: | Question | If YES | If NO | |----------|--------|-------| | Is the issue real? (verify in code) | Continue evaluation | Push back with evidence | | Does the suggested fix work here? | Continue evaluation | Propose alternative | | Does fixing this break something else? | Fix both or push back | Implement the fix | | Is this a style preference or a real problem? | Acknowledge, deprioritize | Fix it | | Was this already considered and rejected? | Explain the trade-off | Implement | ## How to Push Back When feedback is wrong or doesn't apply: ```markdown > Reviewer: "This function should handle null input" > > Response: "Checked — this function is only called from `processUser()` > (line 47) which validates non-null before dispatch. Adding null handling > here would be dead code. The caller contract guarantees non-null." ``` Provide: 1. What you checked 2. Why the suggestion doesn't apply 3. Evidence (line numbers, call sites, tests) ## Multi-Provider Review Context In Claude Octopus workflows, review feedback comes from multiple sources: - **Codex review** — tends toward enterprise patterns, may over-engineer - **Gemini review** — tends toward ecosystem conformity, may suggest unnecessary deps - **Claude review** — tends toward elegance, may under-engineer error handling - **Sonnet review** — tends toward thoroughness, may flag low-priority issues When providers disagree: - Check which provider's suggestion matches the ACTUAL codebase conventions - The codebase's existing patterns win over any provider's preferences - If two providers flag the same issue, it's probably real ## Handling Feedback Loops When a reviewer flags an issue and you fix it: 1. Make the fix 2. **Run verification** (skill-verification-gate) — prove the fix works 3. **Re-read the original feedback** — did you address the root cause or just the symptom? 4. If the reviewer re-reviews and finds new issues, that's normal — don't get frustrated 5. Each round should have FEWER issues, not different ones If the same issue keeps coming back: - You're fixing symptoms, not the root cause - Stop and re-read the feedback from scratch - Ask the reviewer to clarify if the issue is ambiguous ## When Review Feedback Conflicts with Requirements If a reviewer suggests something that contradicts the spec/requirements: 1. Note the conflict explicitly 2. Check if the spec is wrong (it might be) 3. If spec is correct: implement the spec, note the reviewer's concern for future consideration 4. If spec is wrong: flag to the user before changing anything **Requirements trump review suggestions. User intent trumps both.**
Related in Code Review
gstack
IncludedFast headless browser for QA testing and site dogfooding. Navigate pages, interact with elements, verify state, diff before/after, take annotated screenshots, test responsive layouts, forms, uploads, dialogs, and capture bug evidence. Use when asked to open or test a site, verify a deployment, dogfood a user flow, or file a bug with screenshots. (gstack)
startup-due-diligence
IncludedLegal due diligence review for seed-stage and Series A startups (US, Delaware C-Corp focus). Supports both investor and founder perspectives. Capabilities include: (1) Interactive document review and issue spotting; (2) Document request list generation; (3) Cap table and SAFE/convertible note analysis; (4) Red flag identification with severity ratings; (5) Diligence report generation. TRIGGERS: due diligence, DD, startup investment, cap table review, Series A, seed round, investor diligence, legal review startup, SAFE analysis, convertible note, 409A, founder vesting.
interview-master
IncludedThis skill should be used when the user asks to "generate interview questions", "prepare for interview", "optimize resume", "conduct mock interview", "analyze git commits for resume", "generate resume from code", "review my resume", or mentions interview preparation, career assistance, or extracting project experience from git history. Provides comprehensive interview and career development guidance for both job seekers and interviewers.
fix-issue
IncludedFixes GitHub issues using parallel analysis agents for root cause investigation, code exploration, and regression detection. Reads issue context from gh CLI, searches codebase and memory for related patterns, generates a fix with tests, and links the resolution back to the issue via PR. Includes prevention analysis to avoid recurrence. Use when debugging errors, resolving regressions, fixing bugs, or triaging issues.
sf-apex
IncludedGenerates and reviews Salesforce Apex code with 150-point scoring. TRIGGER when: user writes, reviews, or fixes Apex classes, triggers, test classes, batch/queueable/schedulable jobs, or touches .cls/.trigger files. DO NOT TRIGGER when: LWC JavaScript (use sf-lwc), Flow XML (use sf-flow), SOQL-only queries (use sf-soql), or non-Salesforce code.
swift-development
IncludedComprehensive Swift development for building, testing, and deploying iOS/macOS applications. Use when Claude needs to: (1) Build Swift packages or Xcode projects from command line, (2) Run tests with XCTest or Swift Testing framework, (3) Manage iOS simulators with simctl, (4) Handle code signing, provisioning profiles, and app distribution, (5) Format or lint Swift code with SwiftFormat/SwiftLint, (6) Work with Swift Package Manager (SPM), (7) Implement Swift 6 concurrency patterns (async/await, actors, Sendable), (8) Create SwiftUI views with MVVM architecture, (9) Set up Core Data or SwiftData persistence, or any other Swift/iOS/macOS development tasks.