tests-or-not-done

Included with Lifetime

$97 forever

Use when adding or modifying non-trivial code - requires happy-path AND sad-path tests covering every return permutation, blocks declaring "done" if production code grew without matching test additions.

Code Review

What this skill does


# Tests Or Not Done

## Why this skill exists

User's global CLAUDE.md, verbatim: "Every function worth testing should
have both success and error cases. Ensure tests cover every return... for
ex if a Rust function returns an Option ensure that both the Some and None
cases are covered. ... Use table driven tests when possible."

This rule is in his global config and does not propagate reliably to
Codex sessions. ~14 prior corrections of the form "Did you write tests to
comprehensively cover this? With both success and error cases?"

## When this fires

You added or significantly modified a function, method, or pure
transformation. Excludes:
- Pure comment / doc edits
- Dependency bumps
- Configuration-only changes
- One-line typo fixes

## Required behavior

For each function changed, identify:

1. **Return type permutations.** `Option<T>` -> `Some` and `None`.
   `Result<T, E>` -> `Ok` and each `E` variant worth distinguishing.
   `(T, error)` (Go) -> both permutations. `bool` -> true and false branches.
2. **Happy path.** At least one test demonstrating the typical use.
3. **Sad path(s).** One test per error/edge variant: invalid input,
   missing data, out-of-range, race condition, partial failure.
4. **Table-driven where applicable.** Multiple permutations of the same
   shape -> table-driven, one test function with a case list.

Before declaring done, run the tests and report the count by file. If
the test count did not grow alongside the production diff, surface this
explicitly and explain why (e.g., "this is a pure refactor with full
existing coverage").

## Anti-patterns

- "Tests pass" without saying which tests, or which were added.
- One happy-path assertion per function.
- Testing the framework instead of the logic (`assert mock.called`).
- Mocking the database in integration tests when the user's stack supports
  a real one (per his recurring "don't mock what you can run" preference).

## Override

If the change is genuinely untestable in isolation (e.g., a hardware
driver, a UI render verified separately by `verify-ui-changes`), say so
and propose the alternative verification.

Files: 1

Size: 2.3 KB

Complexity: 6/100

Category: Code Review

Source: https://github.com/pbdeuchler/llm-plugins/tree/main/plugins/house-rules/skills/tests-or-not-done

Related in Code Review

gstack

Included

Fast headless browser for QA testing and site dogfooding. Navigate pages, interact with elements, verify state, diff before/after, take annotated screenshots, test responsive layouts, forms, uploads, dialogs, and capture bug evidence. Use when asked to open or test a site, verify a deployment, dogfood a user flow, or file a bug with screenshots. (gstack)

Code Reviewscriptsfeatured

startup-due-diligence

Included

Legal due diligence review for seed-stage and Series A startups (US, Delaware C-Corp focus). Supports both investor and founder perspectives. Capabilities include: (1) Interactive document review and issue spotting; (2) Document request list generation; (3) Cap table and SAFE/convertible note analysis; (4) Red flag identification with severity ratings; (5) Diligence report generation. TRIGGERS: due diligence, DD, startup investment, cap table review, Series A, seed round, investor diligence, legal review startup, SAFE analysis, convertible note, 409A, founder vesting.

Code Reviewscripts

interview-master

Included

This skill should be used when the user asks to "generate interview questions", "prepare for interview", "optimize resume", "conduct mock interview", "analyze git commits for resume", "generate resume from code", "review my resume", or mentions interview preparation, career assistance, or extracting project experience from git history. Provides comprehensive interview and career development guidance for both job seekers and interviewers.

Code Reviewscripts

fix-issue

Included

Fixes GitHub issues using parallel analysis agents for root cause investigation, code exploration, and regression detection. Reads issue context from gh CLI, searches codebase and memory for related patterns, generates a fix with tests, and links the resolution back to the issue via PR. Includes prevention analysis to avoid recurrence. Use when debugging errors, resolving regressions, fixing bugs, or triaging issues.

Code Reviewscripts

sf-apex

Included

Generates and reviews Salesforce Apex code with 150-point scoring. TRIGGER when: user writes, reviews, or fixes Apex classes, triggers, test classes, batch/queueable/schedulable jobs, or touches .cls/.trigger files. DO NOT TRIGGER when: LWC JavaScript (use sf-lwc), Flow XML (use sf-flow), SOQL-only queries (use sf-soql), or non-Salesforce code.

Code Reviewscripts

swift-development

Included

Comprehensive Swift development for building, testing, and deploying iOS/macOS applications. Use when Claude needs to: (1) Build Swift packages or Xcode projects from command line, (2) Run tests with XCTest or Swift Testing framework, (3) Manage iOS simulators with simctl, (4) Handle code signing, provisioning profiles, and app distribution, (5) Format or lint Swift code with SwiftFormat/SwiftLint, (6) Work with Swift Package Manager (SPM), (7) Implement Swift 6 concurrency patterns (async/await, actors, Sendable), (8) Create SwiftUI views with MVVM architecture, (9) Set up Core Data or SwiftData persistence, or any other Swift/iOS/macOS development tasks.

Code Reviewscripts